Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update componentWillMount to use setState #2

Open
mynameistechno opened this issue Jun 21, 2018 · 1 comment
Open

Update componentWillMount to use setState #2

mynameistechno opened this issue Jun 21, 2018 · 1 comment

Comments

@mynameistechno
Copy link

First off, thanks for this module. This is exactly what I need. Second, heads up, React now throws a warning if you set state directly in componentWillMount instead of using setState:

index.js:2214 Warning: SpinnerComponent.componentWillMount(): Assigning directly to this.state is deprecated (except inside a component's constructor). Use setState instead.

image

It also seems like componentWillUpdate will be deprecated altogether in React 17 ...

Cheers!
@Simply007
Copy link
Contributor

I have fixed the issue in #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mynameistechno @Simply007