Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgetize #5

Merged
merged 10 commits into from
Feb 3, 2016
Merged

Widgetize #5

merged 10 commits into from
Feb 3, 2016

Conversation

nshafer
Copy link
Collaborator

@nshafer nshafer commented Jan 28, 2016

Hi Nar, Chhantyal,

I like your module, and I really like selectize.js, and will be using it in a new project. I thought that using a custom widget instead of modifying django templates would make for an easier install and integration. I also needed to updated it for Django 1.9, so I thought I'd go ahead and make a few changes while I was in there. I also made sure it works with Python 2.7 and 3.4. I'm developing with 3.4, but a lot are still on 2.7. Anyways, here are my tweaks.

Thanks,
Nate

@nshafer
Copy link
Collaborator Author

nshafer commented Jan 28, 2016

Oh, this should also resolve issue #1.

@chhantyal
Copy link
Owner

Oh that's very good idea. Thank you.

I am still stuck with bit older version of django, but I will test/review it in next couple of days. 👍

@nshafer
Copy link
Collaborator Author

nshafer commented Jan 28, 2016

Of course =)

I think it would probably work with older versions of Django, but I haven't tested. I normally just target current supported releases =)

@chhantyal
Copy link
Owner

Hi @nshafer
I released a version with this PR #4

This adds 1.9 compatibility without other changes. I plan to release another version with your changes. Could you your PR?

Thanks

@nshafer
Copy link
Collaborator Author

nshafer commented Feb 1, 2016

I have merged your changes in to my PR, so it's ready for merging again. Let me know if you see any problems and I'll take care of them.

chhantyal added a commit that referenced this pull request Feb 3, 2016
@chhantyal chhantyal merged commit cbbcdbb into chhantyal:master Feb 3, 2016
@chhantyal
Copy link
Owner

Thank you. Will bump version to 2.0 with your changes.

@nshafer
Copy link
Collaborator Author

nshafer commented Feb 3, 2016

No problem, thanks for the module =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants