-
Notifications
You must be signed in to change notification settings - Fork 115
recursive entry grouping for huge collections #35
Conversation
btw, I'm not good at naming things, so if it's confusing, I would be glad to hear your suggestions :) |
@chibicode please take a look! |
@alexkuz I will asap, sorry I've been gone in Lake Tahoe last week |
From a very cursory glance this looks 👍 to me. |
recursive entry grouping for huge collections
@alexkuz published 0.6.0. I'll try to merge other PRs and publish 0.6.1 but not sure when I'll get to that |
@alexkuz trying to figure out how to incorporate this PR after the refactoring - could you help me out? https://github.com/chibicode/react-json-tree/pull/36/files |
Thanks! |
From what I've seen it's not an issue that's affecting react-devtools-inspector anymore, but I'm not sure if that's because of these changes or what you've changed in rdi (i.e. it may be an issue that could still affect someone using react-json-tree). I'll take a look tonight and get back asap. |
(there's a lot of changes, I'm sorry for that, it probably shouldn't be in one PR)
Object
,Array
orIterable
has more thancollectionLimit
entries (50
by default), onlycollectionLimit
entries are shown, the rest are grouped recursively (so than not more thancollectionLimit
groups are shown). IfcollectionLimit = 0
, all items are shown.Example screencast (as a part of redux-devtools-inspector):
postprocessValue(value)
(identity
by default): allows to replace value on rendering. Useful for huge collections, as there is no need to traverse all entries, just the ones that are rendered.isCustomNode(value)
(returnsfalse
by default): if returnstrue
, item is rendered viaJSONValueNode
, which allows to render custom component for any type of item (not just literals). Should be used withvalueRenderer
.expandAll = true
.