fix(start()): locate parent before every 'start()' #56
Conversation
When the ng-view is attached to the body And the route is changed The the body may be re-written out from under the loading bar And the $parent object will be invalid By finding the $parent every time the loading bar is started, it ensures that the <div> elements aren't attached to a stale parent.
|
If this needs more work before it can be merged, please let me know. :) |
|
Sorry for the delay and thanks for the help! So this is related to a change I thought I had already made (4937d6c) but apparently never merged. It turns out it's a bad idea to allow someone to specify where in the DOM the loading bar gets inserted because in addition to what you noticed, it can also cause bugs like #12 and even another project of mine had similar issues chieffancypants/angular-hotkeys#8. This seems like a simple enough work around for the time being though. Thanks for the PR! |
|
Landed in 124d631 |
|
Thanks, Chief! :D On Fri, May 2, 2014 at 9:20 AM, Wes Cruver notifications@github.com wrote:
|
When the (ng|ui)-view is attached to the body
And the route is changed
Then the body may be re-written out from under the loading bar
And the $parent pointer will be left in a bad state
By finding the $parent every time the loading bar is started,
it ensures that the loading bar's <div> elements aren't attached
to a stale parent.
I discovered this bug on a project I'm working on. I tested this
fix, and it seemed to do the trick. The loading bar still vanishes
part-way through a route change, but it begins working again
the next time start() is called. (Prior to this fix, it did not.)
More details: We're using ui-router and attaching our app to the
body element. <body ui-view>...</body>