Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bus Route Stats and Modal have different CSS used to create similar appearances #101

Open
hkier opened this issue Aug 9, 2023 · 2 comments
Labels
bug Something isn't working Clean Up

Comments

@hkier
Copy link
Collaborator

hkier commented Aug 9, 2023

There are currently two ways to obtain a display of the route statistics. One is via the modal when the user clicks on a route or searches for it. The second is clicking on the link to display more detailed information.

.../route-stats/9
or
.../map

While the intent is to eventually provide further details on the route-stats page, there is repeated information. The problem is these elements do not use the same CSS styling class names. This adds complexity to the code and will cause a change to only appear in one place. The elements should use the same class name on the various places. If a difference in styling is required CSS selectors should be used to accomplish this. This issue might be resolved as part of another issue when the CSS is modified to reduce the vertical white space on mobile devices.

@hkier hkier added bug Something isn't working Clean Up labels Aug 9, 2023
@robertmiddlekauff
Copy link

i'll take a look at this

@robertmiddlekauff
Copy link

@hkier i tried to do some cleanup here in #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Clean Up
Projects
None yet
Development

No branches or pull requests

2 participants