FPGA CI: Fix NTP clock sync, panic-after-softlock, and systemd init order #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlmahowa-amd
approved these changes
Jan 18, 2024
Previously, we were setting this as if it was a timeout value, but it's actually just a boolean. See https://www.infradead.org/~mchehab/kernel_docs/admin-guide/sysctl/kernel.html#softlockup-panic
Before this change, systemd hadn't fully initialized when the startup script was run (as it was blocking continued startup).
GitHub rejects runners with a local clock that varies by more than 15 minutes. Unfortunately, the RTC on the zcu104 boards is terrible, drifting more than 30 seconds a day.
korran
force-pushed
the
fpga-image-fix
branch
from
c78f7b3 to
5b6f390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fpga-image: Synchronize clock via NTP.
GitHub rejects runners with a local clock that varies by more than 15
minutes. Unfortunately, the RTC on the zcu104 boards is terrible,
drifting more than 30 seconds a day.
fpga-image: Run startup script after everything else.
Before this change, systemd hadn't fully initialized when the startup
script was run (as it was blocking continued startup).
fpga-image: Use softlock_panic sysctl correctly.
Previously, we were setting this as if it was a timeout value, but it's
actually just a boolean.
See
https://www.infradead.org/~mchehab/kernel_docs/admin-guide/sysctl/kernel.html#softlockup-panic