Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement set_apb_pauser method for ModelEmulated. #1681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement set_apb_pauser method for ModelEmulated. #1681

wants to merge 1 commit into from

Conversation

rusty1968
Copy link
Contributor

Bare minimum pauser emulation.

@rusty1968 rusty1968 marked this pull request as ready for review October 21, 2024 17:15
@rusty1968 rusty1968 self-assigned this Oct 21, 2024
@rusty1968 rusty1968 force-pushed the pauser-emu-phase1 branch 5 times, most recently from 83c2725 to 4c93c99 Compare October 24, 2024 15:56
jlmahowa-amd
jlmahowa-amd previously approved these changes Oct 24, 2024
View reviewed changes
@JohnTraverAmd JohnTraverAmd enabled auto-merge (squash) November 20, 2024 01:04
nquarton
nquarton approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@nquarton nquarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked out this PR and did some testing with it. Looks like it is working correctly and DPE sees different localities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nquarton nquarton nquarton approved these changes

@jlmahowa-amd jlmahowa-amd jlmahowa-amd left review comments

@korran korran Awaiting requested review from korran korran is a code owner

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@mhatrevi mhatrevi Awaiting requested review from mhatrevi mhatrevi is a code owner

@jhand2 jhand2 Awaiting requested review from jhand2 jhand2 is a code owner

@swenson swenson Awaiting requested review from swenson swenson is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@bluegate010 bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@rusty1968 rusty1968

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rusty1968 @jlmahowa-amd @nquarton