emulator: Add Zba,Zbc,Zbs instruction sets #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
requested review from
korran,
mhatrevi,
ajisaxena and
vsonims
as code owners
And enables support in code generation to use them. This saves X, Y, and Z bytes in the ROM, FMC, and Runtime, respectively. This has the negative side effect of making tests a little slower to run due to the quantity of macros used in generating all of the test cases. This work extends the previous Zbb bit manipulation instruction set we supported to include the rest of the b family, all of which are supported by our VeeR CPU. We also add missing tests for the Zbb instruction set.
ArthurHeymans
approved these changes
Dec 3, 2024
mhatrevi
approved these changes
Dec 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And enables support in code generation to use them. This saves 44, 8, and 168 bytes in the ROM, FMC, and Runtime, respectively.
This has the negative side effect of making tests a little slower to run due to the quantity of macros used in generating all of the test cases.
This work extends the previous Zbb bit manipulation instruction set we supported to include the rest of the b family, all of which are supported by our VeeR CPU.
We also add missing tests for the Zbb instruction set.
(This work was done to support the MCU firmware, which needs the space and performance benefits more. So there's no reason not to bring it back here for "free".)