Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PersistentDataAccessor in FMC firmware. #703

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

korran
Copy link
Collaborator

@korran korran commented Aug 29, 2023

The PersistentDataAccessor is introduced in #690 (Add safe abstraction for accessing persistent data).

FerralCoder
FerralCoder previously approved these changes Aug 29, 2023
@korran korran marked this pull request as ready for review August 29, 2023 21:26
@korran korran changed the base branch from kor-persistent-data to main August 31, 2023 19:41
@korran korran dismissed FerralCoder’s stale review August 31, 2023 19:41

The base branch was changed.

@korran korran requested review from jhand2 and fdamato as code owners August 31, 2023 19:41
@korran korran force-pushed the persistent-data-fmc branch 2 times, most recently from 0f6edfb to f5c8173 Compare August 31, 2023 20:57
@korran korran requested a review from FerralCoder August 31, 2023 21:20
@korran korran force-pushed the persistent-data-fmc branch from f5c8173 to 68fee96 Compare August 31, 2023 21:21
@korran korran force-pushed the persistent-data-fmc branch from b5ab072 to 3139318 Compare August 31, 2023 21:24
rusty1968
rusty1968 previously approved these changes Sep 5, 2023
FerralCoder
FerralCoder previously approved these changes Sep 5, 2023
@korran korran dismissed stale reviews from FerralCoder and rusty1968 via b9b7e9a September 5, 2023 21:19
@korran korran requested a review from rusty1968 September 5, 2023 23:04
@korran korran merged commit 22f3e56 into chipsalliance:main Sep 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants