Reconstruct IDevId cert at runtime #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHeymans
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
mhatrevi,
ajisaxena,
vsonims and
korran
as code owners
|
I'm not sure how to properly write tests for this other than some minimal validations like size. The fuses contain 0 in this setup. |
jhand2
reviewed
Aug 30, 2023
ArthurHeymans
force-pushed
the
ArhurHeymans/idevid
branch
from
259a1e6 to
ef9621d
Compare
ArthurHeymans
force-pushed
the
ArhurHeymans/idevid
branch
3 times, most recently
from
a0c9794 to
bdb957b
Compare
|
Changed the mailbox as requested to have the signature as input. |
jhand2
previously approved these changes
Sep 1, 2023
jhand2
force-pushed
the
ArhurHeymans/idevid
branch
from
bdb957b to
bc685a8
Compare
|
PR looks good, there's just a CI failure after rebasing. I'll merge once that is fixed. |
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Retrieve the IDevId cert signature from fuses and append it to the mailbox input data. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
This adds documentation for the GET_IDEV_CERT and GET_IDEV_INFO commands. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
auto-merge was automatically disabled
September 1, 2023 13:03
Head branch was pushed to by a user without write access
ArthurHeymans
force-pushed
the
ArhurHeymans/idevid
branch
from
bc685a8 to
00c5deb
Compare
Done. |
jhand2
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 2 mailbox commands:
Closes #294