Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticDB requires private fields of case class to use "val" #3270

Merged
merged 1 commit into from
May 9, 2023

Conversation

jackkoenig
Copy link
Contributor

This does not seem to be required by Scala, but it is required by newer versions of SemanticDB (and thus to use Scala Metals).

Workaround for scalameta/scalameta#3122.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This does not seem to be required by Scala, but it is required by newer
versions of SemanticDB (and thus to use Scala Metals).
@jackkoenig jackkoenig added the Internal Internal change, does not affect users, will be included in release notes label May 9, 2023
@jackkoenig jackkoenig added this to the 3.5.x milestone May 9, 2023
@jackkoenig jackkoenig merged commit 08369ef into main May 9, 2023
@jackkoenig jackkoenig deleted the fix-semanticdb branch May 9, 2023 23:11
@mergify mergify bot added the Backported This PR has been backported label May 9, 2023
mergify bot pushed a commit that referenced this pull request May 9, 2023
This does not seem to be required by Scala, but it is required by newer
versions of SemanticDB (and thus to use Scala Metals).

(cherry picked from commit 08369ef)
mergify bot pushed a commit that referenced this pull request May 9, 2023
This does not seem to be required by Scala, but it is required by newer
versions of SemanticDB (and thus to use Scala Metals).

(cherry picked from commit 08369ef)
mergify bot pushed a commit that referenced this pull request May 9, 2023
This does not seem to be required by Scala, but it is required by newer
versions of SemanticDB (and thus to use Scala Metals).

(cherry picked from commit 08369ef)
mergify bot added a commit that referenced this pull request May 9, 2023
…#3272)

This does not seem to be required by Scala, but it is required by newer
versions of SemanticDB (and thus to use Scala Metals).

(cherry picked from commit 08369ef)

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request May 9, 2023
…#3271)

This does not seem to be required by Scala, but it is required by newer
versions of SemanticDB (and thus to use Scala Metals).

(cherry picked from commit 08369ef)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@sequencer sequencer mentioned this pull request Jun 20, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant