-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Vec dynamic index with a literal to static index #3314
Conversation
66e9a7a
to
fd3eeb1
Compare
if (p.isLit) { | ||
return this.apply(p.litValue.intValue) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aswaterman has reminded me that we actually support out-of-bounds indices currently which means this could cause some currently working code to become an error. I'm going to change this to not accidentally change semantics and open a separate PR making those out-of-bounds indices a warning à la #3033.
fd3eeb1
to
4a68cdf
Compare
(cherry picked from commit e20a038)
(cherry picked from commit e20a038)
This reduces the amount of work that both Chisel and firtool have to do.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x
or3.6.x
depending on impact, API modification or big change:5.0.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.