Have checkpoint report (and clear) non-fatal errors. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
approved these changes
Nov 21, 2016
|
Style: can you use a common function for the two? It seems one handles a fatal path while the other isn't fatal, shouldn't the printing be common code? Right now it looks like two wildly separate code paths. |
|
I'm afraid trying to come up with common code to handle the printing will just make things more complicated with little benefit. Feel free to prove me wrong. |
|
retest this please |
mwachs5
pushed a commit
that referenced
this pull request
Dec 29, 2022
Bumps [chisel3](https://github.com/freechipsproject/chisel3) from `294bf10` to `044b062`. - [Release notes](https://github.com/freechipsproject/chisel3/releases) - [Commits](294bf10...044b062) --- updated-dependencies: - dependency-name: chisel3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.