Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builderreflectionfix #515

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Builderreflectionfix #515

merged 2 commits into from
Feb 17, 2017

Conversation

shunshou
Copy link
Contributor

Should supersede #456 @sdtwigg @ducky64

Copy link
Contributor

@ducky64 ducky64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ducky64
Copy link
Contributor

ducky64 commented Feb 17, 2017

Make sure you do a squash merge, so that the broken commit doesn't make it into the main tree (in case there's someone out there playing with bisect or something)

@shunshou shunshou merged commit 50db343 into master Feb 17, 2017
@edwardcwang edwardcwang deleted the builderreflectionfix branch March 15, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants