Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check message does not reflect version checking behavior #14

Open
brendonsb opened this issue Feb 9, 2021 · 0 comments
Open

Comments

@brendonsb
Copy link

In build.sh, check_version() checks if the installed version is greater than the supplied version argument ($2). Then the warning message on failure states that the version needs to at least the value ($2).

Either the warning should state the version needs to be greater than $2 or the comparison check needs to be changed to >= from >.

As is, script will fail with automake version 1.14

..../rocket-tools (master)$ ./build.sh 
Starting RISC-V Toolchain build process
OpenOCD build requires at least version 1.14 of automake. Aborting.
..../rocket-tools (master)$ automake --version
automake (GNU automake) 1.14
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <tromey@redhat.com>
       and Alexandre Duret-Lutz <adl@gnu.org>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant