Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve root_dir and workspace_folders paths before starting LSP client #16

Closed
chipsenkbeil opened this issue Aug 9, 2021 · 1 comment
Labels
bug Something isn't working quick Some issue that can be resolved quickly (<1 hour) wontfix This will not be worked on

Comments

@chipsenkbeil
Copy link
Owner

If the directory is a symlink, we can have a problem where none of the files are triggered because they have the canonicalized file path whereas the root dir (and workspace folder dirs) keep whatever is provided in settings.

Because of that, we need to send a metadata request for each of these directories to set the appropriate path at time of client start.

This also would benefit from supporting batch requests, which starts by implementing chipsenkbeil/distant#20

@chipsenkbeil chipsenkbeil added the bug Something isn't working label Aug 9, 2021
@chipsenkbeil chipsenkbeil added this to the v0.2 milestone Oct 19, 2021
@chipsenkbeil chipsenkbeil added the quick Some issue that can be resolved quickly (<1 hour) label Feb 1, 2022
@chipsenkbeil chipsenkbeil modified the milestones: v0.2.0, v0.3.0 May 15, 2023
@chipsenkbeil chipsenkbeil removed this from the v0.3.0 milestone Jun 26, 2023
@chipsenkbeil chipsenkbeil added the wontfix This will not be worked on label Jun 26, 2023
@chipsenkbeil
Copy link
Owner Author

Not going to do this now. Given that #86 is available, the user can do this when configuring the root_dir.

If we want to use workspace_folders, a separate issue could be filed to support async configuration of LSP as a whole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quick Some issue that can be resolved quickly (<1 hour) wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant