Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API to make headers available so we can provide an external option to search settings #211

Open
chipsenkbeil opened this issue Jun 28, 2023 · 1 comment
Labels
breaking Would require breaking changes refactor Refactor portions of codebase
Milestone

Comments

@chipsenkbeil
Copy link
Owner

Could be a boolean like external = true to let the implementation pick an external process to execute.

Or could be a string like external = "ripgrep" to specify the external process to use.

Or is this needed? distant-ssh2 has to use an external process. distant-local uses an internal version of ripgrep.

@chipsenkbeil chipsenkbeil added refactor Refactor portions of codebase breaking Would require breaking changes labels Jun 28, 2023
@chipsenkbeil chipsenkbeil added this to the 0.20 milestone Jun 28, 2023
@chipsenkbeil chipsenkbeil modified the milestones: 0.20, Backlog, 1.0 Jul 14, 2023
@chipsenkbeil
Copy link
Owner Author

Do we have to include options? Or can we just enable the header for a request to be available as part of the api? The header route would enable us to add features like this without breaking protocol, so I'm going to move 1.0 milestone while this is considered.

@chipsenkbeil chipsenkbeil changed the title Add external option to search settings Update API to make headers available so we can provide an external option to search settings Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Would require breaking changes refactor Refactor portions of codebase
Projects
None yet
Development

No branches or pull requests

1 participant