Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IERC721Enumerable impl to an extension #69

Closed
syffs opened this issue Feb 3, 2022 · 2 comments · Fixed by #107
Closed

Move IERC721Enumerable impl to an extension #69

syffs opened this issue Feb 3, 2022 · 2 comments · Fixed by #107

Comments

@syffs
Copy link

syffs commented Feb 3, 2022

I don't think everyone needs this on-chain, and considering the risks of DOS related to an O(totalSupply) method (tokenOfOwnerByIndex), I do think it'd make a lot of sense to have this implemented in an extension.
@syffs syffs mentioned this issue Feb 8, 2022
Closed
@fulldecent
Copy link
Contributor

O(totalSupply) was the death of the CryptoKitties approach :-)

@0xsudo-eth
Copy link

Totally agree with @syffs and was about to raise this

@fulldecent fulldecent mentioned this issue Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove tokenOfOwnerByIndex fulldecent/ERC721A
3 participants
@fulldecent @syffs @0xsudo-eth