Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance to make pty.js compatible with Node 0.11.x ? #88

Closed
Unitech opened this issue Sep 15, 2014 · 9 comments
Closed

Any chance to make pty.js compatible with Node 0.11.x ? #88

Unitech opened this issue Sep 15, 2014 · 9 comments

Comments

@Unitech
Copy link

Unitech commented Sep 15, 2014

I manage to modify and install pty.js but it doesn't work with Node.js 0.11.13.

Is there any plan or any patch that could make it work with newer node version ?

Thanks

@jshkurti
Copy link

I would be highly interested in this as well :)

@mralexgray
Copy link

+1

@jshkurti
Copy link

jshkurti commented Oct 7, 2014

Related issue : nodejs/node-v0.x-archive#8468

@EloB
Copy link

EloB commented Oct 14, 2014

+1

1 similar comment
@jespermjonsson
Copy link

+1

@thedaniel
Copy link

Does the related issue @jshkurti linked mean that this library cannot be updated until that is fixed?

@jshkurti
Copy link

Probably, I forked pty.js a while ago and tried to make it V8-compatible with Node 0.11.x, it didn't work either.
So yeah I guess it can't be fixed until nodejs/node-v0.x-archive#8468 is fixed.

@rektide
Copy link

rektide commented Aug 27, 2015

Activity in that node ticket, asking if this is still a problem.

@jshkurti
Copy link

It has been fixed a while ago by @chjj I don't remember the exact commit.
I guess we can close this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants