Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builds artifacts for linux arm64 #152

Closed
tcurdt opened this issue Apr 10, 2022 · 10 comments
Closed

builds artifacts for linux arm64 #152

tcurdt opened this issue Apr 10, 2022 · 10 comments
Assignees
Labels
A-CI Area: Relating to CI P-linux Platform: Linux

Comments

@tcurdt
Copy link

tcurdt commented Apr 10, 2022

It would be great to also have linux arm64 binaries for releases.

@balupton
Copy link

I've ended up adopting sd quite heavily inside https://github.com/bevry/dorothy - a cross-platform dotfile ecosystem - and noticed that on arm devices (such as my raspberry pis) it needs to download rust to compile itself, which is unfortunate, as it means installing Dorothy needs to install rust.

Out of other rust packages that Dorothy provides installers for, I've noticed:

Perhaps the necessary build tooling could be pulled from them?

@balupton
Copy link

Microsoft has a cross-platform builder for ripgrep, maybe that will be helpful:

https://github.com/microsoft/ripgrep-prebuilt

@yhakbar
Copy link
Contributor

yhakbar commented Apr 14, 2023

I cut a release on my fork to support this, as I needed this for support on Graviton instances:
https://github.com/yhakbar/sd/releases/tag/v0.7.7-yhakbar

Hopefully, once #179 is merged in, we can fetch this from a release on this repo.

@CosmicHorrorDev CosmicHorrorDev self-assigned this May 12, 2023
@CosmicHorrorDev CosmicHorrorDev added A-CI Area: Relating to CI P-linux Platform: Linux M-needs triage Meta: Maintainer label me! labels May 17, 2023
@CosmicHorrorDev CosmicHorrorDev added this to the v0.8.0 Release milestone May 17, 2023
@balupton
Copy link

I'm guessing the release of this is pending on #200

balupton added a commit to bevry/dorothy that referenced this issue Aug 18, 2023
@CosmicHorrorDev
Copy link
Collaborator

I'm guessing the release of this is pending on #200

More or less yes. There are a couple of things that I want to get cleaned up before the next release, and the next release will fix this issue

I'm very pressed for time currently and probably will be for the next month or so. PRs are welcome of course

@yhakbar
Copy link
Contributor

yhakbar commented Aug 18, 2023

I'm guessing the release of this is pending on #200

More or less yes. There are a couple of things that I want to get cleaned up before the next release, and the next release will fix this issue

I'm very pressed for time currently and probably will be for the next month or so. PRs are welcome of course

Take your time @CosmicHorrorDev !

Not to rush you or anything, but do you have things that you need PRs for before the next release? Happy to chip in if I can help.

I think you mentioned that you needed some more CI work done. I can take a look at that if there's a relevant issue blocking the release.

@CosmicHorrorDev
Copy link
Collaborator

I can throw together a tracking issue later today. Any help would be greatly appreciated 🙏

@CosmicHorrorDev
Copy link
Collaborator

@yhakbar I threw together a tracking issue in #203 if anything in there looks of interest to you. Overall there are only a few different things I want handled before things are set for a new release

@yhakbar
Copy link
Contributor

yhakbar commented Aug 19, 2023

Is this considered blocking for the release @CosmicHorrorDev ? I think the work to get aarch64-unknown-linux-musl targets built during the release is already merged in and present on main. If not, then I guess we'll close it after the next release.

@CosmicHorrorDev
Copy link
Collaborator

I believe you're right that the work for this is already merged. I'll go ahead and close this since the next release should be very soon

@CosmicHorrorDev CosmicHorrorDev removed the M-needs triage Meta: Maintainer label me! label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Relating to CI P-linux Platform: Linux
Projects
None yet
Development

No branches or pull requests

4 participants