Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a feature to toggle on/off the option to not attempt to download icons for packages #811

Closed
gep13 opened this issue Feb 12, 2021 · 3 comments
Closed

Add a feature to toggle on/off the option to not attempt to download icons for packages #811

gep13 opened this issue Feb 12, 2021 · 3 comments
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone
0.18.0

Comments

@gep13
Copy link
Member

gep13 commented Feb 12, 2021 •
edited
Loading

NOTE: While this feature toggle will exist within the OSS version of Chocolatey GUI, it will not be used, and this feature will only be acted on by the Chocolatey GUI Licensed Extension.

Related issue was created here: chocolatey/chocolatey-licensed-issues#199
@gep13 gep13 added the Feature Issues that introduce new functionality to the project, instead of updating existing functionality label Feb 12, 2021
gep13 added a commit that referenced this issue Feb 12, 2021
@gep13
(GH-811) Add feature toggle for icon download
bdb6568 
This feature won't actually do anything in the OSS version of Chocolatey
GUI, but it will be used in the Chocolatey GUI Licensed Extension to
override the functionality of downloading icons.
@gep13 gep13 added this to the 0.18.0 milestone Feb 12, 2021
@gep13 gep13 closed this as completed Feb 12, 2021
@gep13 gep13 reopened this Feb 12, 2021
@gep13
Copy link
Member Author

gep13 commented Feb 12, 2021

Re-opening this, as there will be some work to make it possible to override this functionality in the Chocolatey GUI Licensed Extension.

gep13 added a commit that referenced this issue Feb 12, 2021
@gep13
(GH-811) Move logic for icon into service
eb0635c 
This will allow this functionality to be overridden in the Chocolatey GUI
Licensed Extension.
gep13 added a commit that referenced this issue Feb 12, 2021
@gep13
Merge branch 'feature/GH-811' into develop
f443257 
* feature/GH-811:
  (maint) Corrected comment on registrations
  (GH-811) Move logic for icon into service
@gep13
Copy link
Member Author

gep13 commented Feb 12, 2021

The core logic within the InternetImage control has been extracted into a PackageIconService, which will mean that this can be overridden when required.

@gep13 gep13 closed this as completed Feb 12, 2021
gep13 added a commit that referenced this issue Feb 13, 2021
@gep13
(GH-811) Add coloured Chocolatey logo
5f21a14 
This will be used as default package icon when choosing to not download
package icon URLs.
gep13 added a commit that referenced this issue Feb 13, 2021
@gep13
(GH-811) Further additions to PackageIconService
6ca6932 
Move the methods of getting the empty icon and error icon into the
PackageIconService as well.  This will allow these to also be overridden
in the Chocolatey GUI Licensed Extension, if required.
gep13 added a commit that referenced this issue Feb 16, 2021
@gep13
(GH-811) Add new feature to ToString output
d09be61 
This should have been included earlier, but it was overlooked.
@gep13 gep13 changed the title Add feature toggle to prevent attempting to download icons for packages Add a feature to toggle on/off the option to not attempt to download icons for packages Mar 8, 2021
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot