Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure WiX installer verifies that .NET Framework 4.8 is installed #842

Closed
gep13 opened this issue Apr 13, 2021 · 1 comment · Fixed by #847
Closed

Ensure WiX installer verifies that .NET Framework 4.8 is installed #842

gep13 opened this issue Apr 13, 2021 · 1 comment · Fixed by #847
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.20.0

Comments

@gep13
Copy link
Member

gep13 commented Apr 13, 2021

As a follow up to this issue: #841 we need to update the WiX installer to ensure that .NET Framework 4.8 is installed.

This is really belts and braces, since we have updated the dependency on the Chocolatey package to ensure that it is installed, however, if installing the MSI directly, it wouldn't install correctly if this check isn't there.

When I attempted to make this change, the result was the following:

image

I installed the the 3.14 version from the development downloads section: https://wixtoolset.org/releases/development/ as it was mentioned here: https://github.com/wixtoolset/wix3/blob/develop/src/chm/documents/customactions/wixnetfxextension.html.md#properties that this was required, but it still chose not to work.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Apr 13, 2021
@gep13 gep13 added this to the 0.19.0 milestone Apr 13, 2021
nils-a added a commit to nils-a/ChocolateyGUI that referenced this issue Apr 20, 2021
@nils-a
(chocolatey#842) added a check for NET Framework 4.8
80eb61b 
in the installer.
@nils-a nils-a mentioned this issue Apr 20, 2021
Merged
gep13 pushed a commit to nils-a/ChocolateyGUI that referenced this issue May 1, 2021
@nils-a @gep13
(chocolatey#842) added a check for NET Framework 4.8
daacae7 
in the installer.
@gep13 gep13 closed this as completed in #847 May 1, 2021
gep13 added a commit that referenced this issue May 1, 2021
@gep13
Merge pull request #847 from nils-a/feature/GH-842
d015ab3 
(#842) added a check for NET Framework 4.8
@AdmiringWorm AdmiringWorm added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label Jan 21, 2022
@gep13
Copy link
Member Author

gep13 commented Feb 10, 2022

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@corbob corbob added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

(#842) added a check for NET Framework 4.8 nils-a/ChocolateyGUI
3 participants
@gep13 @AdmiringWorm @corbob