Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pester tests #1033

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Update pester tests #1033

merged 2 commits into from
Dec 20, 2023

Conversation

corbob
Copy link
Member

@corbob corbob commented Dec 20, 2023

Description Of Changes

Update the pester tests to be consistent with the other Chocolatey repositories.

Motivation and Context

Consistency in Pester test location and behaviour.

Testing

These pester tests are not currently part of any Test Kitchen environment. As such, the only tests we have are a manual running of these tests:

  1. Install Chocolatey CLI in Windows Sandbox.
  2. Install chocolateygui and pester packages.
  3. Run Invoke-Pester in the tests/pester-tests directory.

image

Operating Systems Testing

Windows 10 22H2

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Pester test changes

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@corbob
(tests) Move the Pester tests to be consistent
8514c94 
The pester tests in the rest of the Chocolatey repositories reside in a
tests/pester-tests directory. This moves the tests to be consistent with
the other repositories.
@corbob
(tests) Update Pester tests to be consistent
8d431e9
gep13
gep13 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 09e5632 into chocolatey:develop Dec 20, 2023
2 checks passed
@gep13
Copy link
Member

gep13 commented Dec 20, 2023

@corbob thanks for getting these fixed up!

This was referenced Dec 20, 2023
Merged
Merged
@corbob corbob deleted the adjust-tests branch December 21, 2023 14:15
@corbob corbob mentioned this pull request Dec 21, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corbob @gep13