Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build scripts to call the base script. #3483

Open
2 tasks done
corbob opened this issue Jul 12, 2024 · 0 comments
Open
2 tasks done

Update Build scripts to call the base script. #3483

corbob opened this issue Jul 12, 2024 · 0 comments

Comments

@corbob
Copy link
Member

corbob commented Jul 12, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

No response

Describe The Solution. Why is it needed?

When using the build.debug.bat and build.official.bat file, they are mirrors of build.bat with the addition of the desired -Configuration <Configuration> parameter. They also then leave off the configuration as being provided to the Cake build script, when in fact it is. This presents two concerns for our future selves: First: if the method of launching the build.ps1 needs to change (say setting an environment variable first), we need to make the change in all of the build scripts. Second: as it stands, the build.sh variants diverge from the build.bat in that they all call the build.sh while the build.bat variants duplicate the build.bat.

Proposal is to update the debug and official scripts to just call the build.bat with the desired configuration.

Additional Context

We will want to ensure that a failing build returns the exit code correctly. This can be done by purposely breaking the build and running each build.bat script and then inspecting the exit code.

Related Issues

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant