You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have verified this is the correct repository for opening this issue.
I have verified no other issues exist related to my request.
Is Your Feature Request Related To A Problem? Please describe.
No response
Describe The Solution. Why is it needed?
When using the build.debug.bat and build.official.bat file, they are mirrors of build.bat with the addition of the desired -Configuration <Configuration> parameter. They also then leave off the configuration as being provided to the Cake build script, when in fact it is. This presents two concerns for our future selves: First: if the method of launching the build.ps1 needs to change (say setting an environment variable first), we need to make the change in all of the build scripts. Second: as it stands, the build.sh variants diverge from the build.bat in that they all call the build.sh while the build.bat variants duplicate the build.bat.
Proposal is to update the debug and official scripts to just call the build.bat with the desired configuration.
Additional Context
We will want to ensure that a failing build returns the exit code correctly. This can be done by purposely breaking the build and running each build.bat script and then inspecting the exit code.
Related Issues
No response
The text was updated successfully, but these errors were encountered:
Checklist
Is Your Feature Request Related To A Problem? Please describe.
No response
Describe The Solution. Why is it needed?
When using the
build.debug.bat
andbuild.official.bat
file, they are mirrors ofbuild.bat
with the addition of the desired-Configuration <Configuration>
parameter. They also then leave off the configuration as being provided to the Cake build script, when in fact it is. This presents two concerns for our future selves: First: if the method of launching thebuild.ps1
needs to change (say setting an environment variable first), we need to make the change in all of the build scripts. Second: as it stands, the build.sh variants diverge from the build.bat in that they all call the build.sh while the build.bat variants duplicate the build.bat.Proposal is to update the debug and official scripts to just call the build.bat with the desired configuration.
Additional Context
We will want to ensure that a failing build returns the exit code correctly. This can be done by purposely breaking the build and running each build.bat script and then inspecting the exit code.
Related Issues
No response
The text was updated successfully, but these errors were encountered: