(GH-1401) Added initial call to Chocolatey after installation #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -700,4 +701,17 @@ param( | |||
| } | |||
| } | |||
|
|
|||
| function Run-Chocolatey { | |||
| Write-Debug "Running Chocolatey..." | |||
There was a problem hiding this comment.
Do we call write-debug elsewhere in here or does it have another name?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, I borrowed Write-Debug from elsewhere 😄
| $chocoInstallationFolder = Get-ChocolateyInstallFolder | ||
| $chocoExe = Join-Path -Path $chocoInstallationFolder -ChildPath "choco.exe" | ||
| & $chocoExe | Out-Null | ||
| Write-Debug "Chocolatey execution completed successfully." |
There was a problem hiding this comment.
tabs versus spaces. Also ensure all line endings are CRLF
ferventcoder
requested changes
Feb 22, 2018
| @@ -700,4 +701,17 @@ param( | |||
| } | |||
| } | |||
|
|
|||
| function Invoke-Chocolatey { | |||
| Write-Debug "Running Chocolatey..." | |||
There was a problem hiding this comment.
Initializing Chocolatey files, etc by running Chocolatey...
- This ensures that all necessary setup is completed - Ready for further execution
ferventcoder
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1401