Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#997) Highlight Active page #1011

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

st3phhays
Copy link
Member

Description Of Changes

The change here ensures the left side navigation
always highlights the active page. This also
makes sure that an expanded navigation item does
not collapse on reload. The trailing slash, or
lack of, has been accounted for now.

Motivation and Context

We want to ensure the left side navigation works.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.
  1. Pull down the pr
  2. Run yarn dev, ensure the left side navigation is working properly. Try adding and removing slashes on the url to see that it just "works".
  3. Close the preview terminal, and run yarn build
  4. Run yarn preview
  5. Try adding and removing slashes on the url to see that it just "works".

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

Relates to #997

The change here ensures the left side navigation
always highlights the active page. This also
makes sure that an expanded navigation item does
not collapse on reload. The trailing slash, or
lack of, has been accounted for now.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit b58ffd9 into chocolatey:master Jun 13, 2024
1 check passed
@gep13
Copy link
Member

gep13 commented Jun 13, 2024

@st3phhays thanks for getting this fixed up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants