Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new function to nvme module - get_log() #44

Open
robsonsmartins opened this issue Sep 13, 2023 · 2 comments
Open

Add new function to nvme module - get_log() #44

robsonsmartins opened this issue Sep 13, 2023 · 2 comments

Comments

@robsonsmartins
Copy link

robsonsmartins commented Sep 13, 2023

The proposal is to add a new function to the nvme module: get_log(), which is capable of calling the command line nvme get-log <device_path> -i <log_id> -l <log_len> -b and returning the requested log as a Vec::<u8> (a byte array).

The interface of this function will be:

pub fn get_log(dev: &Path, id: u8, len: u16) -> BlockResult<Vec<u8>> {}

PR: #45

Reference: https://manpages.debian.org/testing/nvme-cli/nvme-get-log.1.en.html

@cholcombe973
Copy link
Owner

Thanks for doing this. I've merged the PR. Would you like me to cut a release or are there more PRs you think you'd like to add first?

@robsonsmartins
Copy link
Author

I think this is a good time to create a release tag with the changes already incorporated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants