Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hui/html #146

Merged
merged 2 commits into from
Apr 25, 2019
Merged

add hui/html #146

merged 2 commits into from
Apr 25, 2019

Conversation

mafintosh
Copy link
Contributor

We use this as a shorthand in our HUI component, https://github.com/hyperdivision/hui

@emilbayes
Copy link

@goto-bus-stop @bcomnes Can we merge this? :)

@goto-bus-stop
Copy link
Member

goto-bus-stop commented Apr 25, 2019 •
edited
Loading

this list is duplicated in lib/babel.js (nanohtmlModuleNames variable), could it be updated there as well? the babel plugin has an option to specify custom module names, but the default should be the same ideally.

e; or the list could be moved to a separate module so we don't have to duplicate them anymore :D

@mafintosh
Copy link
Contributor Author

@goto-bus-stop fixed

@goto-bus-stop goto-bus-stop merged commit 3431a15 into choojs:master Apr 25, 2019
@goto-bus-stop
Copy link
Member

📦 1.6.0

@mafintosh mafintosh deleted the patch-1 branch April 25, 2019 09:43
@ungoldman ungoldman mentioned this pull request Apr 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ungoldman ungoldman ungoldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mafintosh @emilbayes @goto-bus-stop @ungoldman