Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a regression test for resetCounters behaviour #147

Open
chris48s opened this issue Dec 27, 2021 · 0 comments
Open

Write a regression test for resetCounters behaviour #147

chris48s opened this issue Dec 27, 2021 · 0 comments

Comments

@chris48s
Copy link
Owner

I added this in f59bf3b to reset the counters after we've finished validating each file. Without it, callLimit is applied across multiple file validations. I didn't add a test for it though.

TODO: Add a test (at cli level) that validates 11 files and asserts we can call a mock https://www.schemastore.org/api/json/catalog.json 11 times (rather than throwing Called https://www.schemastore.org/api/json/catalog.json >10 times. Possible circular reference).

@chris48s chris48s changed the title Write a regression test for resetCounters behaviour Write a regression test for resetCounters behaviour Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant