Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DizqueTV-Python Support #849

Open
Bradisverycool opened this issue Oct 10, 2024 · 5 comments
Open

DizqueTV-Python Support #849

Bradisverycool opened this issue Oct 10, 2024 · 5 comments
Labels
wontfix This will not be worked on

Comments

@Bradisverycool
Copy link

Is your feature request related to a problem? Please describe.
There is a app called CommercialBreaker which is a dizquetv toonami simulator but it uses DizqueTV-Python but the dev for CommercialBreaker said that DizqueTV-Python is not supported in tunarr
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
Add support for Dizquetv-Python
A clear and concise description of what you want to happen.

Describe alternatives you've considered
Currently there are non alts to CommercialBreaker or Dizquetv Python that has Tunarr support
A clear and concise description of any alternative solutions or features you've considered.

Additional context
The CommercialBreaker is located here https://github.com/theweebcoders/CommercialBreaker
Add any other context or screenshots about the feature request here.

@chrisbenincasa
Copy link
Owner

Hey thanks for the bug. I am not really familiar with dizquetv-python (and have minimal experience with python in general). I'm gonna add in the maintainer of DTV-python here (cc: @nwithan8) in case they have any additional thoughts (and since they contributed the original Unraid template for Tunarr many months back.

I think supporting this isn't really that simple, since Tunarr has completely changed all of the DTV APIs at this point - there are no original endpoints left. As such, we'd need an entirely fresh write of a python wrapper around the Tunarr API. I'd be happy to support / work with somebody who is interested in taking on this task, but I most likely won't be doing it myself.

@chrisbenincasa chrisbenincasa added the wontfix This will not be worked on label Oct 10, 2024
@Bradisverycool
Copy link
Author

ok

@nwithan8
Copy link
Contributor

l'd be happy to support / work with somebody who is interested in taking on this task, but I most likely won't be doing it myself.

That's why I'm here :) Admittedly, haven't looked at the API to see what kind of undertaking it would involve. I've also evolved a lot as a dev since writing the Python library for dizqueTV (was one of my first major projects), so I would want to start from scratch regardless.

Is there an OpenAPI spec or something I can look at?

I was also unaware that anything beyond my dizqueTV Python scripts repo (and one webhook project) actually used the dizqueTV library, nice to know.

@Bradisverycool
Copy link
Author

i am not the owner of repo or have openapi but here is a link to CommercialBreaker https://github.com/theweebcoders/CommercialBreaker

@chrisbenincasa
Copy link
Owner

@nwithan8 there is, but it's not public (only available on a running instance of the server)

I'm working on #856 which will also publish a version of the docs to the github repo

@chrisbenincasa chrisbenincasa moved this to Todo in Tunarr Nov 6, 2024
@chrisbenincasa chrisbenincasa removed this from Tunarr Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants