Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visuals for dialogs #93

Closed
chrisglein opened this issue Mar 17, 2023 · 0 comments · Fixed by #116
Closed

Improve visuals for dialogs #93

chrisglein opened this issue Mar 17, 2023 · 0 comments · Fixed by #116
Labels
enhancement New feature or request

Comments

@chrisglein
Copy link
Owner

chrisglein commented Mar 17, 2023

WinUI dialog:
Image

Current dialog:
Image

Can't get that bottom solid color because the corners need to be rounded on bottomLeft and bottomRight but not the top edge. And Windows doesn't support that :/

Having the default button selected would be good. But the RN Button has a color property that sets the background but doesn't update the foreground to match (and keep contrast ratios clean).

The icons are very nonstandard and I should probably drop them.

@chrisglein chrisglein converted this from a draft issue Mar 17, 2023
@chrisglein chrisglein moved this to Todo in Artificial Chat Mar 17, 2023
@chrisglein chrisglein added the enhancement New feature or request label Mar 17, 2023
@chrisglein chrisglein moved this from Todo to In Progress in Artificial Chat Apr 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Artificial Chat Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant