Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post process or ignores before diff #38

Open
yasirroni opened this issue Dec 27, 2022 · 1 comment
Open

post process or ignores before diff #38

yasirroni opened this issue Dec 27, 2022 · 1 comment

Comments

@yasirroni
Copy link

Hi, I'm a contributor of nb-clean. I use that to clean execution count and metadata of notebook before push any commit. Do you accept any contribution around skipping execution count and metadata diff? I think it haven't been implemented by you.

I think there are two possibilities.

  1. Do a post process that run git filter on the notebook before it is cleaned.
  2. Parameters to clean diff based on the given argument

Option 2 is better I think. Since nbdime support ignores

Then, the question is, does this package respect nbdime config nbdime_config.json?

@yasirroni yasirroni changed the title post process before diff post process or ignores before diff Dec 27, 2022
@yasirroni
Copy link
Author

After some testing, it seems that pytest-notebook ignores nbdime_config.json, both on the pytest target folder and on root folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant