-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing sell orders because quantity doubles #512
Comments
Please export the log and upload it here. So can see what exactly happened. |
Sure, with pleasure. Luckily the issue was still in the log file, for your reference I have listed the IDs below so it is more easy to search through. Hope you find a solution! 10:58:49.935 - id=633169c9d7c6a3394960f22a - Order still in tact (quantity 3.29) Logfile: |
Hello @eppenga, @chrisleekr I can see this from the log (locked value is equal to -3.29) {
"asset": "SOL",
"free": 6.59,
"locked": -3.29,
"total": 3.3,
"estimatedValue": 109.824,
"updatedAt": "2022-09-26T08:59:50.548Z",
"isLessThanMinNotionalValue": false
}, ExplainationI am sure this is happening because of the race condition between WebSocket and the following function:
The expected behavior:
"asset": "SOL",
"free": "3.30000000",
"locked": "0.00000000"
"asset": "SOL",
"free": "3.30000000",
"locked": "0.00000000" The actual behavior (which is happened here):
"asset": "SOL",
"free": "3.30000000",
"locked": "0.00000000"
"asset": "SOL",
"free": "6.59000000",
"locked": "-3.29000000" @chrisleekr do you have any suggestion to improve this ? |
I had some thoughts. I think we shouldn't use We should replace any place using Thoughts? |
Yeah, to be honest, the same idea comes to my mind. We should use |
Hello @chrisleekr, @eppenga I just pushed a pull request to solve this. |
Thank you @habibalkhabbaz ! Much appreciated! |
Just installed the new version, thank you, will let you know if it happens again, but don't think so looking at the code! |
I am experiencing a similar issue as in #451 and in my case sometimes the quantity of the order doubles (it does not create double orders). Please see here an example of my log below, also for you @uhliksk and @habibalkhabbaz
At 10:58:49.935 the order is still in tact and shows a quantity of 3.29 SOL to be sold:
At 10:59:50.619 the quantity suddenly jumps to double (3.29 * 2 = 6.58 SOL), no additional buy orders were performed as you can see:
This then corrupts the sell order (because it only has 3.29 and is trying to sell 6.58 SOL) and all future orders leading to a failure to sell.
For the record, I am using the last version v0.0.90 (48865a0).
The text was updated successfully, but these errors were encountered: