Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow nan in column_dropper_transformer #41

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix: allow nan in column_dropper_transformer #41

merged 2 commits into from
Jan 16, 2023

Conversation

premsrii
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@839ba5a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #41   +/-   ##
==========================================
  Coverage           ?   99.28%           
==========================================
  Files              ?        8           
  Lines              ?      419           
  Branches           ?        0           
==========================================
  Hits               ?      416           
  Misses             ?        3           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@chrislemke chrislemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@premsrii premsrii requested a review from chrislemke January 16, 2023 09:34
@premsrii premsrii merged commit 772d717 into develop Jan 16, 2023
@premsrii premsrii deleted the allow_nan branch January 16, 2023 09:56
premsrii added a commit that referenced this pull request Jan 16, 2023
These transformers now accept dataframes with nan values.
- ColumnDropperTransformer
- DtypeTransformer
- LeftJoinTransformer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants