fix(v-model): fix trim modifier on events with non-string args ( (vue…

…js#5770) fix vuejs#5765
chrislone · Feb 4, 2023 · 08e5991 · 08e5991
1 parent 1a2fb93
commit 08e5991
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/packages/runtime-core/__tests__/componentEmits.spec.ts b/packages/runtime-core/__tests__/componentEmits.spec.ts
@@ -385,6 +385,28 @@ describe('component: emit', () => {
     expect(fn2).toHaveBeenCalledTimes(1)
     expect(fn2).toHaveBeenCalledWith(1)
   })
+
+  test('only trim string parameter when work with v-model on component', () => {
+    const Foo = defineComponent({
+      render() {},
+      created() {
+        this.$emit('update:modelValue', ' foo ', { bar: ' bar ' })
+      }
+    })
+
+    const fn = jest.fn()
+    const Comp = () =>
+      h(Foo, {
+        modelValue: null,
+        modelModifiers: { trim: true },
+        'onUpdate:modelValue': fn
+      })
+
+    render(h(Comp), nodeOps.createElement('div'))
+
+    expect(fn).toHaveBeenCalledTimes(1)
+    expect(fn).toHaveBeenCalledWith('foo', { bar: ' bar ' })
+  })
 
   test('isEmitListener', () => {
     const options = {

diff --git a/packages/runtime-core/src/componentEmits.ts b/packages/runtime-core/src/componentEmits.ts
@@ -8,6 +8,7 @@ import {
   isArray,
   isFunction,
   isObject,
+  isString,
   isOn,
   toNumber,
   UnionToIntersection
@@ -122,7 +123,7 @@ export function emit(
     }Modifiers`
     const { number, trim } = props[modifiersKey] || EMPTY_OBJ
     if (trim) {
-      args = rawArgs.map(a => a.trim())
+      args = rawArgs.map(a => isString(a) ? a.trim() : a)
     }
     if (number) {
       args = rawArgs.map(toNumber)