Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordcloud implodes with high numbers of words #5

Closed
webisteme opened this issue Jan 22, 2019 · 2 comments
Closed

Wordcloud implodes with high numbers of words #5

webisteme opened this issue Jan 22, 2019 · 2 comments
Labels

Comments

@webisteme
Copy link

webisteme commented Jan 22, 2019

The upper bound of fontScale's range is always 100, regardless of how many words are displayed or the size of the SVG canvas. This leads to intermittent collisions between words at high volumes (> 150). As a solution, I suggest setting the upper bound dynamically based on the ratio between the number of words and the SVG area size. This should allow the package to render large numbers of words without collisions by adjusting the fonts size dynamically. I will submit a Pull request if you are interested (and also if you are not).

@chrisrzhou
Copy link
Owner

@webisteme, awesome please feel free to submit a PR! I plan to revisit and modernize this component in March when I find some time.

Thanks for debugging it and finding a fix for it!

@chrisrzhou chrisrzhou added the bug label Mar 11, 2019
@chrisrzhou
Copy link
Owner

Should be fixed to some extent for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants