GUID and DateTime? checks in Validate method

[awdorrin]

I am attempting to generate C# Client code using .net8.0 and an openapi.yml file using the openapi generator.
Since this is the first time doing this, I'm not sure if this is an issue with this tool, or the openapi generator itself.
But I am getting checks in the validation code that look like this:

 if (this.EntityUUID != null && this.EntityUUID.Length > 255)
 {
     yield return new ValidationResult("Invalid value for EntityUUID, length must be less than 255.", new [] { "EntityUUID" });
 }
 
if (this.VendorEffectiveStartDate != null && this.VendorEffectiveStartDate.Length > 19)
{
    yield return new ValidationResult("Invalid value for VendorEffectiveStartDate, length must be less than 19.", new [] { "VendorEffectiveStartDate" });
}

Now, I think this is a result of how the YML is being defined and a difference in format and type definitions, and how the generator is trying to convert to native formats (GUID, DateTime)

        entityUUID:
          format: uuid
          title: Entity UUID
          description: ""
          maxLength: 255
          type: string
          xml:
            attribute: true
          example: ""
          nullable: false

        vendorEffectiveStartDate:
          format: date-time
          title: vendorEffectiveStartDate
          maxLength: 19
          type: string
          example: 2024-02-07T00:00:00
          nullable: true
          x-sip: eo.hcm.ecfs.sip.lmpi.general
          x-label: Effective Start Date
          x-sap-source: VendorInfo.effectiveStartDate
          x-field-category: FIELD

I am assuming, I could do a simple .ToString() in front of the length check, but, since this is the first encounter with this, I am not entirely sure, and I have not found anything on my searching yet.

Thanks for any suggestions

[christianhelle]

This tool purely piggybacks on other code generators. Generators like NSwag, Kiota, OpenAPI Generator, and Refitter will respect (or at least try their best) to implement what is described in the OpenAPI document

@awdorrin Do you know what version of the OpenAPI specifications is being used here? Can you share the OpenAPI document?

[awdorrin]

I can't share the openapi doc, as it contains proprietary information for my company.
The document is being generated as 'openapi: 3.0.3' from an SAP system.
From what I have learned since I posted, I think the issue is a combination of the content of the openapi file and the openapi-generator-cli for csharp.

The developer responsible for the openapi spec file claims that the 'maxLength' fields are being sent by SAP, if I remove or comment out those entries, openapi-generator-cli produces appropriate code (actually, it does not generate any validator code for the GUID or DateTime datatypes, which is better)
I have run into other issues that I also believe is an issue with the openapi file being generated, where data values are containing "null" but there is no nullable: true flag in the spec file - in fact, a few with nulls actually have nullable: false

I think this tool is pretty cool, thanks for creating it. It is so much better than manually writing 'BeforeCompile' directives in my .csproj file :-)