Add CancellationToken cancellationToken = default to generated Methods

[kirides]

Currently the generated code looks like this

[Post("/v1/Endpoint")]
Task EndpointPOST([Body] EndpointV1 body);

To support timeouts etc. it would be nice to get refitter to add the CancellationToken-parameter like this

[Post("/v1/Endpoint")]
Task EndpointPOST([Body] EndpointV1 body, CancellationToken cancellationToken = default);

[christianhelle]

@kirides This is trivial to implement and I can get started with this immediately. Unless you want to give it a shot yourself?

[kirides]

We're currently in the evaluation phase of deciding to use this tool to generate our clients, sadly i can't provide an implementation at this stage... bureaucracy

[christianhelle]

I'm currently trying this out and I can see that Refit doesn't seem to like CancellationToken cancellationToken = default

I generated this code

[Get("/pet/{petId}")]
Task<Pet> GetPetById(long petId, CancellationToken cancellationToken = default);

But when I run it I just get a Make sure it has at least one method with a Refit HTTP method attribute and Refit is installed in the project. error when I run the generated code

Unhandled exception. System.InvalidOperationException: ISwaggerPetstore doesn't look like a Refit interface. Make sure it has at least one method with a Refit HTTP method attribute and Refit is installed in the project.
   at Refit.RestService.GetGeneratedType(Type refitInterfaceType) in /_/Refit/RestService.cs:line 173
   at Refit.RestService.For(Type refitInterfaceType, HttpClient client, IRequestBuilder builder) in /_/Refit/RestService.cs:line 76
   at Refit.RestService.For[T](HttpClient client, IRequestBuilder`1 builder) in /_/Refit/RestService.cs:line 20
   at Refit.RestService.For[T](HttpClient client, RefitSettings settings) in /_/Refit/RestService.cs:line 34
   at Refit.RestService.For[T](String hostUrl, RefitSettings settings) in /_/Refit/RestService.cs:line 54
   at Refit.RestService.For[T](String hostUrl) in /_/Refit/RestService.cs:line 65
   at MyNamespace.Program.TestPetstoreUsingDirectTypes() in C:\projects\christianhelle\refitter\test\ConsoleApp\Program.cs:line 34
   at MyNamespace.Program.Main(String[] args) in C:\projects\christianhelle\refitter\test\ConsoleApp\Program.cs:line 11
   at MyNamespace.Program.<Main>(String[] args)

I'm investigating as why this is

[kirides]

Sounds interesting, manually specifying it in a .NET 6.0 project works fine.

Here is the code from refit that checks for its existence (many places call that, and other chains also check for its existence)
https://github.com/reactiveui/refit/blob/ef463956936fcdfd248d120672fe0bb7ff93d5ac/Refit/RequestBuilderImplementation.cs#L474

[christianhelle]

@kirides did you get the interface containing a CancellationToken in the arguments to work? I have no luck with this. I already have the code for generating an interface that uses CancellationToken as the last argument but I can't get the interface to work

[kirides]

Using Refit 6.0.1 & 6.3.2 this works flawlessly:
(Cancellation also works like it should)

[christianhelle]

@kirides I honestly couldn't get CancellationToken to work, but if your example works then I trust you on that. Generating code that uses CancellationTokens was trivial to implement and I expect to release this feature this in the afternoon

[christianhelle]

This feature is now released as v0.5.0