Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with prior PR (undefined variable) #9

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix: issue with prior PR (undefined variable) #9

merged 1 commit into from
Nov 17, 2020

Conversation

joshgoebel
Copy link
Contributor

Sorry, the finer points of JS escaping me (at a glance). Assigning it directly to a variable means it's never defined in the outer scope so line 27 breaks. :( I was more focused on the build results than the execution.

So sorry. I built and tested this time.

@joshgoebel
(chore) fix issue with prior PR (undefined variable)
4a6f4f1 
Sorry, the finer points of JS escaping me (at a glance).  Assigning it directly to a variable means it's never defined in the outer scope so line 27 breaks. :(  I was more focused on the build results than the execution.

So sorry.  I built and tested this time.
@reviewflow
Copy link
Contributor

reviewflow bot commented Nov 17, 2020 •
edited
Loading

Options:

  • This PR is a feature branch
  • Add [skip ci] on merge commit
  • Auto merge when this PR is ready and has no failed statuses. (Also has a queue per repo to prevent multiple useless "Update branch" triggers)
  • Automatic branch delete after this PR is merged

@reviewflow reviewflow bot added the 👌 code/approved Synced by reviewflow for code/approved label Nov 17, 2020
@christophehurpeau
Copy link
Owner

Yes I should also add tests in this repo :/

@christophehurpeau christophehurpeau changed the title (chore) fix issue with prior PR (undefined variable) fix: issue with prior PR (undefined variable) Nov 17, 2020
@christophehurpeau christophehurpeau merged commit afa9596 into christophehurpeau:master Nov 17, 2020
@christophehurpeau
Copy link
Owner

Released in 1.4.1 ! Thanks

@christophehurpeau christophehurpeau mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophehurpeau christophehurpeau christophehurpeau approved these changes

Assignees

@joshgoebel joshgoebel

Labels
👌 code/approved Synced by reviewflow for code/approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgoebel @christophehurpeau