-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using this module creates an empty comment block on the generated page #142
Using this module creates an empty comment block on the generated page #142
Comments
ReproductionI've been able to figure out the root cause and a work around. It appears that the blank comment is rendered when two conditions are met:
When the conditions are met, the WorkaroundThis can be exploited to achieve a section header by doing two things:
The desired content can be markdown or an include, both work. Here is an example: /**
* # Welcome to My Module!
* This is great stuff.
*
* ```ts
* let codeBlocks = 'work'; // as expected!
* ```
* [[include:fileFromIncludeFolder.md]]
*
* @module FOO
*/
/**
* Here is my model class.
*/
export class MyFoo {
name: string;
} The following compact variant works as well: /** [[include:fileFromIncludeFolder.md]] @module FOO */
/**
* Here is my model class.
*/
export class MyFoo {
name: string;
} Everything from the first comment will end up on the module's landing page, and everything after will render as expected on the page for the The 'merge module'This plugin looks for an existing module to rename to the desired name. It refers to this as the merge target. After processing is complete, it will then remove the As a result, to take advantage of the work around you have to either locate the file while the plugin will choose as the merge target, or you need to put the landing page content on every class file that you assign to a given module. I have not yet seen a pattern that allows one to predict which module will become the merge target, so I've initially used trial and error. So far both merge target modules were simple model classes, and lexicographic sort order of the file paths did not seem to influence the process. |
File 1 (with @module comment):
File 2 (without @module comment):
The text was updated successfully, but these errors were encountered: