Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't work with 'css_color.vim' #4

Open
gadamiak opened this issue Jun 16, 2011 · 10 comments
Open

It doesn't work with 'css_color.vim' #4

gadamiak opened this issue Jun 16, 2011 · 10 comments

Comments

@gadamiak
Copy link

css_color.vim applies colored background for color definitions and is a great tool for CSS. However, it stops working with your syntax file. It works with a stock css.vim without problems.

@chrisyip
Copy link
Owner

coz i used a lot of regexp for highlights in order to provide a simple ssyntax checker -- only perfect matched keyword will be highlighted.
but seems it will conflict with some plugin (those plugin cannot support complex regexp), i'm considering to rewrite this plugin with less regexp and write a new plugin to do the checking job.

@gadamiak
Copy link
Author

... only perfect matched keyword will be highlighted.

I only use hex and rgba notations.

'css_color.vim' is loaded from after/syntax/ folder so it should not conflict,
however it is. I'm not familiar with syntax files, so I can't tell.

Have you thought about submitting your syntax file as patch to Vim?

BTW, have you thought about updating csscomplete.vim? You've put all post 2.1
stuff anyway, so maybe updating it wouldn't require you to do so much work?

So many questions, sorry :)

@chrisyip
Copy link
Owner

'css_color.vim' is loaded from after/syntax/ folder so it should not conflict,
it's due to vim's syntax feature, if one rule is too complex, the others won't be applied.

Have you thought about submitting your syntax file as patch to Vim?
no... coz it isn't stable enough to submit to vim as patch

BTW, have you thought about updating csscomplete.vim?
i've never use this plugin before, mainly i use autocomplpro.
i'll have a try about it

@gadamiak
Copy link
Author

i've never use this plugin before, mainly i use autocomplpro.

I meant Vim's 7.3 built-in completion. Now it consists of CSS 2.1 only.

@chrisyip
Copy link
Owner

sorry for replying so late, im quite busy these days.

i've tried the built-in csscomplete.vim, seems not difficult to update it.
added it to my schedule, but not sure when will finish and commit it.

@gadamiak
Copy link
Author

Thanks! That would be really helpful to have it updated :)

@chrisyip
Copy link
Owner

chrisyip commented Jul 4, 2011

hi gadamiak,
here's the css3 supported csscomplete.css
just for preview.
create a /autoload/csscomplete.vim with the above code.
this version only supports properties, values are not included and can't recognize prefix.

btw, you can add your own properties by modifying the "let" sentences on L9 to 28

@millermedeiros
Copy link

+1. it also breaks vim-css-color

@gadamiak
Copy link
Author

It works fine for me with vim-css-color (I'm using VAM to manage my plugins).

@teschmitz
Copy link

It also works fine with https://github.com/chrisbra/color_highlight.
This add-on works not only with css but it can be applied to other filetypes, too, and it has various options to configure the display of the colour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants