Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN] JavaScript Client Tests #2415

Closed
atroyn opened this issue Jun 25, 2024 · 3 comments
Closed

[CLN] JavaScript Client Tests #2415

atroyn opened this issue Jun 25, 2024 · 3 comments

Comments

@atroyn
Copy link
Contributor

atroyn commented Jun 25, 2024

Our JS / TS client tests are currently pretty messy. There doesn't seem to be a clear way to run them locally (running bin/ts-integration-test results in failures which don't appear on the GitHub workers / in CI), and the functionality of the tests is distributed across many files.

Additionally, it does not seem that the JS tests generate a new JS client (see #2412), and they probably should for correct coverage.

It would be good to unify theses tests, make sure they are replicable locally and on CI.

@atroyn
Copy link
Contributor Author

atroyn commented Jun 25, 2024

@AlabasterAxe we might want to take a look at this as part of the current milestone, since we will be modifying JS probably a lot.

@AlabasterAxe
Copy link
Contributor

AlabasterAxe commented Jul 15, 2024

@atroyn I think that a lot of the clutter for the existing tests arises out of setting up and tearing down the test environments. I put together this proof of concept PR which moves the environment setup and teardown into the JS test code:

https://github.com/AlabasterAxe/chroma/pull/5/files?diff=split&w=1

this would allow us to run all of the tests together instead of having to do separate environment setups and teardowns across several jest runs for the various auth configurations

Thoughts?

@AlabasterAxe
Copy link
Contributor

Also, I have this PR which just gets that integration test script running locally: #2518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants