Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notification interactive so that it can show you the changes when you click on it #264

Closed
ghengeveld opened this issue Mar 22, 2024 · 2 comments · Fixed by #281
Closed
Assignees
Labels
enhancement Classification: Improvement to existing feature

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Mar 22, 2024

From AP-4228

image (8)

When build completed and I clicked on the toast notification I expected it to take me to the changes. It did nothing and it also blocked the changes button that would actually take you to the changes.

@ghengeveld ghengeveld added feature Classification: New feature sev:S4 labels Mar 22, 2024
@shilman shilman added enhancement Classification: Improvement to existing feature and removed feature Classification: New feature labels Mar 28, 2024
@shilman shilman added this to the include in sb upgrade milestone Mar 28, 2024
@ghengeveld
Copy link
Member Author

I’m not sure whether this is possible with the current Storybook notification API. I believe it only takes a link which must be a relative URL. I could link it to the first story with changes, but not toggle the Changes filter.

@ghengeveld
Copy link
Member Author

Adding support for duration and onClick to Storybook here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Classification: Improvement to existing feature
Projects
None yet
4 participants