Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestHTTPUnavailable fails #115

Closed
phumpal opened this issue Jun 5, 2020 · 4 comments
Closed

TestHTTPUnavailable fails #115

phumpal opened this issue Jun 5, 2020 · 4 comments

Comments

@phumpal
Copy link

phumpal commented Jun 5, 2020

TestHTTPUnavailable fails as the cert for https://oskuro.net/ has expired

https://www.sslshopper.com/ssl-checker.html#hostname=oskuro.net
@phumpal
Copy link
Author

phumpal commented Jun 5, 2020

I believe this is @jmallach. Gentle ping ^^

@phumpal phumpal mentioned this issue Jun 5, 2020
Merged
8 tasks
@nharper
Copy link
Collaborator

nharper commented Jun 5, 2020

Some tests depend on the behavior of external domains and need to be rewritten to be hermetic.

Duplicate of #112

@nharper nharper closed this as completed Jun 5, 2020
@jmallach
Copy link

jmallach commented Jun 5, 2020

Woops, my LE stuff failed for whatever reason, I renewed the cert during the morning. Thanks!

@phumpal
Copy link
Author

phumpal commented Jun 5, 2020

Awesome thanks @jmallach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nharper @phumpal @jmallach