Use Formatter::pad (instead of write_str) for Weekdays #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, width, alignment and fill from the format string are respected. Fixes chronotope#1620.
djc
approved these changes
Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 37 37
Lines 17129 17137 +8
=======================================
+ Hits 15608 15616 +8
Misses 1521 1521 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way, width, alignment and fill from the format string are respected.
Fixes #1620.
Excellent question whether this is semver-compatible. I'm not 100% sure: On the one hand, this changes behaviour others may be relying on. On the other hand, it is fixing something which may be perceived as a bug. I'll let the reviewer judge and will retarget accordingly.