Add parse_from_* to DateTime #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds conversion to/from Utc, Local, and FixedOffset. Originally planned to go through NaiveDateTime, but it seems that is not necessary?
Documentation added to both `impl`s and functions so that they are visible to both users perusing the online documentation and in autocomplete/intellisense engines.
As discussed in chronotope#263. Note that this breaks existing code that did not explicitly specify the offset in calls to `DateTime::parse_from_*`, as they are now ambiguous. Relies on chronotope#271 for conversion back into `DateTime<Utc>` from `DateTime<FixedOffset>` as the latter is used under the hood.
|
@quodlibetor I don't know if you want to take this alongside #271 as both feature ergonomic improvements to working with timezoned |
|
Nope, just deleted the master branch in response to user confusion. |
|
Ah ok. Do you mind reopening the issue? or do you need me to create a new pr with this rebased against main? |
|
I tried, but was unable to reopen the PR. If you're still interested, please rebase on main. |
|
Re-based and resubmitted as #806. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #263. Note that this breaks existing code that did not
explicitly specify the offset in calls to
DateTime::parse_from_*, asthey are now ambiguous.
Relies on #271 for conversion back into
DateTime<Utc>fromDateTime<FixedOffset>as the latter is used under the hood.