Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building chrono-fuzz #967

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Fix building chrono-fuzz #967

merged 2 commits into from
Apr 14, 2023

Conversation

LingMan
Copy link
Contributor

@LingMan LingMan commented Feb 14, 2023

Updating this was missed when adding `parse_from_xxx` methods to `DateTime<Utc>` in
chronotope@925ca99.
@djc
Copy link
Member

djc commented Feb 14, 2023

I'd like to have most of these changes (except the first one, which I think wouldn't commit) on 0.4.x (from where we'll merge them to main), would you be able to retarget the PR (and rebase the changes)?

@LingMan LingMan changed the base branch from main to 0.4.x February 14, 2023 13:57
@LingMan
Copy link
Contributor Author

LingMan commented Feb 14, 2023

Sure, give me a bit to figure it out.

@djc
Copy link
Member

djc commented Feb 14, 2023

I recommend git rebase -i main, then killing all except the last three non-commented lines.

@LingMan
Copy link
Contributor Author

LingMan commented Feb 14, 2023

Actually, neither the first nor the last commit make sense on 0.4.x and considering chrono-fuzz hasn't been touched in 3 years adding it to CI in a stable branch now doesn't seem fruitful either. I can make a separate PR for that if you really want though.

@LingMan LingMan changed the base branch from 0.4.x to main February 14, 2023 14:33
@djc
Copy link
Member

djc commented Feb 14, 2023

Since most development currently happens on 0.4.x, I would still appreciate such a PR for all the applicable changes.

No functional change but makes this file self-consistent and consistent with the Dependabot docs.
@LingMan LingMan changed the title Fix and update chrono-fuzz Fix building chrono-fuzz Feb 14, 2023
@LingMan
Copy link
Contributor Author

LingMan commented Feb 14, 2023

Here you go: #968.
I've dropped those commits from this PR so it now mostly fixes the chrono-fuzz build.

@esheppa esheppa mentioned this pull request Feb 20, 2023
Copy link
Contributor

@jtmoon79 jtmoon79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also see fuzzing-related Issues in Bug #1010 , PR #603 .

@djc djc merged commit 0a16a65 into chronotope:main Apr 14, 2023
@djc
Copy link
Member

djc commented Apr 14, 2023

Thanks!

@LingMan LingMan deleted the libfuzzer branch April 14, 2023 22:05
@pitdicker pitdicker mentioned this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants