Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept response codes other than 200 #22

Closed
smithamax opened this issue Jan 24, 2011 · 2 comments
Closed

Accept response codes other than 200 #22

smithamax opened this issue Jan 24, 2011 · 2 comments

Comments

@smithamax
Copy link

at the moment if an api request returns a 302 code it is treated as an error.
twitter and facebook both use 302 redirects for getting profile images.
@ciaranj
Copy link
Owner

ciaranj commented Jan 24, 2011

Hmm, fair comment, perhaps we should just test for 4xx and 5xx instead?

@smithamax
Copy link
Author

just found this in the twitter api doc, http://dev.twitter.com/pages/responses_errors
no mention of the 302 but it does give an idea as to what twitter associates with each error, mostly codes are as expected.

4xx and 5xx seems like the right choice.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ciaranj @smithamax