Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanCOGeN template: all null values should be lower case with the first letter of each word capitalized #230

Closed
griffie opened this issue Oct 29, 2021 · 3 comments

Comments

@griffie
Copy link
Contributor

griffie commented Oct 29, 2021

Currently in the NML LIMS export, all the null values reflect those offered by the DH, which are lower case with the first letter of each word capitalized. This is what is needed for LIMS.

However, some users input null values in the free text fields. When they do this programmatically, sometimes those null values are all caps.

Can we ensure that any null value in any field has the proper capitalization?
e.g. "NOT PROVIDED" or "not provided" or "Not provided" should always be "Not Provided".

Thanks!

@ddooley
Copy link
Collaborator

ddooley commented Nov 2, 2021

So each free text field needs to be searched for any of the standard null values, and have Title caps applied to them? This is somewhat computationally intensive; Can we at least say that the entire value of such a field will be a null value? That will speed up comparison.

@griffie
Copy link
Contributor Author

griffie commented Nov 2, 2021

Sure. Let's do that.

@ddooley
Copy link
Collaborator

ddooley commented Nov 9, 2021

I've implemented this just for NML LIMS, in the "vocabulary update" branch.

@ddooley ddooley closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants