Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-sheet Excel export #434

Open
kennethbruskiewicz opened this issue Apr 22, 2024 · 2 comments
Open

Multi-sheet Excel export #434

kennethbruskiewicz opened this issue Apr 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kennethbruskiewicz
Copy link
Collaborator

With issue #431 : rework the file saving to allow for multi-sheet Excel file saving.

@kennethbruskiewicz kennethbruskiewicz added the enhancement New feature or request label Apr 22, 2024
@kennethbruskiewicz kennethbruskiewicz self-assigned this Apr 22, 2024
@kennethbruskiewicz
Copy link
Collaborator Author

kennethbruskiewicz commented Apr 25, 2024

Will come in with https://github.com/cidgoh/DataHarmonizer/tree/dh2-431-export-as-json as I can reuse the same code.

@ddooley the "Save as..." vs the "Export to..." feature – should this only be supported in the "Save as..." feature?

I mention this because "Export to..." seems to be "owned" by the template repository. I'm not sure if it's something to force on every template if each implementation is meant to be different.

@ddooley
Copy link
Collaborator

ddooley commented Apr 25, 2024

"Export to" involves conversion of a given schema to another, so will always involve a menu of specific target formats to map/convert fields to - each usually saved as tab separated data. That's why its different from "save as" which is not mapping fields, its just saving schema content with its own slot fields/names/structure.

Export to function currently often involves adding export.js script to fiddle with fields as they are transformed to target.

Indeed templates don't necessarily need an export option and in fact the "Export to" menu may list nothing if there is no export target predefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants